Initial impl of escaped SOF #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to read it more closely, but at first glance it looks good. I'll try to write some actual unit tests so it can be properly tested. The one-byte-at-a-time is not great, could you try rewriting it so it sends contiguous chunks in one call to TF_WriteImpl? Keep track of the last plain character and then send the "buffered" plain portion before escaping the offending char.. and don't forget to send the leftover at the end of the loop. |
|
This is a good idea to have an escape char . I have seen tf lost the sync with the stream becsuse of sof byte in the middle. So this is a must have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #16
I'm not entirely happy with this impl - while it's simple enough, it completely removes buffering on TF_WriteImpl. I could improve this to fill the buffer with escaped bytes, or split buffer writes on each escaped char, but it's a bit more code refactoring.
I've tested this internally and it works, and when disabled does not affect old code. Thoughts on the 1-byte-at-a-time aspect? Not sure if it's mergeable.
I also have an impl of this for PonyFrame, if you like. It's much simpler, at least.